cli: non-service jobs on job restart -reschedule
#19147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
force-pushed
the
b-cli-handle-job-restart-types
branch
from
14f823b
to
4c7e24e
Compare
lgfa29
added
backport/1.5.x
jrasell
approved these changes
Nov 24, 2023
The `-reschedule` flag stops allocations and assumes the Nomad scheduler will create new allocations to replace them. But this is only true for service jobs. Restarting non-service jobs with the `-reschedule` flag causes the command to loop forever waiting for the allocations to be replaced, which never happens. Allocations for system jobs may be replaced by triggering an evaluation after each stop to cause the reconciler to run again. Batch and sysbatch jobs should not be allowed to be rescheduled as they are expected to run to completion unless stopped.
lgfa29
force-pushed
the
b-cli-handle-job-restart-types
branch
from
96e77cd
to
6f2ea97
Compare
lgfa29
force-pushed
the
b-cli-handle-job-restart-types
branch
from
8e4719b
to
a7588e6
Compare
Batch jobs are able to be rescheduled without further steps, but sysbatch jobs never receive a replacement allocation so they are still not allowed to be rescheduled.
lgfa29
force-pushed
the
b-cli-handle-job-restart-types
branch
from
a7588e6
to
b21fcde
Compare
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-rescheduleflag stops allocations and assumes the Nomad scheduler will create new allocations to replace them. But this is only true for service jobs.Restarting non-service jobs with the
-rescheduleflag causes the command to loop forever waiting for the allocations to be replaced, which never happens.Allocations for system jobs may be replaced by triggering an evaluation after each stop to cause the reconciler to run again.
Batch and sysbatch jobs should not be allowed to be rescheduled as they are expected to run to completion unless stopped.
Closes #19043