Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] HCL-in-UI: Re-arrange buttons, add save-as-file #17752

Merged
merged 4 commits into from
Jun 29, 2023
Merged

[ui] HCL-in-UI: Re-arrange buttons, add save-as-file #17752

merged 4 commits into from
Jun 29, 2023

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented Jun 27, 2023 •
edited
Loading

  • Rearranges buttons when adding a jobspec, or editing an existing jobspec, to be more intuitive
  • Adds a "Download as .nomad.hcl" button when editing, to let users practice good infra-as-code
    image

Resolves #17327

@philrenaud philrenaud self-assigned this Jun 27, 2023
@philrenaud philrenaud linked an issue Jun 27, 2023 that may be closed by this pull request
replace the buttons on the template run job page #17327
Closed
@philrenaud philrenaud marked this pull request as ready for review June 27, 2023 17:52
@github-actions
Copy link

github-actions bot commented Jun 27, 2023 •
edited
Loading

Ember Test Audit comparison

main 0641f88 change
passes 1494 1494 0
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

mikenomitch
mikenomitch approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@mikenomitch mikenomitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM design and functionality-wise

juliezzhou
juliezzhou approved these changes Jun 27, 2023
View reviewed changes
Copy link

@juliezzhou juliezzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@philrenaud philrenaud force-pushed the f-ui/17327-replace-the-buttons-on-the-template-run-job-page branch from 8fc2f62 to bb3cce8 Compare June 28, 2023 19:51
@philrenaud philrenaud merged commit fccfb1d into main Jun 29, 2023
@philrenaud philrenaud deleted the f-ui/17327-replace-the-buttons-on-the-template-run-job-page branch June 29, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliezzhou juliezzhou juliezzhou approved these changes

@mikenomitch mikenomitch mikenomitch approved these changes

@angrycub angrycub Awaiting requested review from angrycub

Assignees

@philrenaud philrenaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace the buttons on the template run job page
3 participants
@philrenaud @mikenomitch @juliezzhou