build: respect GOBIN when using make targets #12077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates GNUMakefile to respect $GOBIN if it is set in the environment or via an $GOENV file. Previously we hard-coded the output to $GOPATH/bin, which is not necessarily the desired behavior.
shoenig
force-pushed
the
b-makefile-use-gobin
branch
from
72326d3 to
06613d6
Compare
shoenig
commented
Feb 16, 2022
| @@ -12,7 +12,13 @@ ifneq (MSYS_NT,$(THIS_OS)) | |||
| # GOPATH supports PATH style multi-paths; assume the first entry is favorable. | |||
| # Necessary because new Circle images override GOPATH with multiple values. | |||
| # See: https://discuss.circleci.com/t/gopath-is-set-to-multiple-directories/7174 | |||
| GOPATH=$(shell go env GOPATH | cut -d: -f1) | |||
| GOPATH := $(shell go env GOPATH | cut -d: -f1) | |||
There was a problem hiding this comment.
drive by improvement (= vs :=)
lgfa29
approved these changes
Feb 16, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
GNUMakefileto respect$GOBINif it is set in theenvironment or via an
$GOENVfile. Previously we hard-coded the outputto
$GOPATH/bin, which is not necessarily the desired behavior.https://pkg.go.dev/cmd/go#hdr-Environment_variables