Prevent kill_timeout greater than progress_deadline (#16761)

* func: add validation for kill timeout smaller than progress dealine * style: add changelog * style: typo in changelog * style: remove refactored test * Update .changelog/16761.txt Co-authored-by: James Rasell <[email protected]> * Update nomad/structs/structs.go Co-authored-by: James Rasell <[email protected]> --------- Co-authored-by: James Rasell <[email protected]>
hashicorp · Apr 5, 2023 · cee21a8 · cee21a8
1 parent dbd33b1
commit cee21a8
Show file tree

Hide file tree

Showing 3 changed files with 427 additions and 331 deletions.
diff --git a/.changelog/16761.txt b/.changelog/16761.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+core: Prevent `task.kill_timeout` being greater than `update.progress_deadline`
+```
diff --git a/nomad/structs/structs.go b/nomad/structs/structs.go
@@ -4933,6 +4933,12 @@ func (u *UpdateStrategy) IsEmpty() bool {
 		return true
 	}
 
+	// When the Job is transformed from api to struct, the Update Strategy block is
+	// copied into the existing task groups, the only things that are passed along
+	// are MaxParallel and Stagger, because they are enforced at job level.
+	// That is why checking if MaxParallel is zero is enough to know if the
+	// update block is empty.
+
 	return u.MaxParallel == 0
 }
 
@@ -6465,6 +6471,8 @@ func (tg *TaskGroup) Validate(j *Job) error {
 		mErr.Errors = append(mErr.Errors, outer)
 	}
 
+	isTypeService := j.Type == JobTypeService
+
 	// Validate the tasks
 	for _, task := range tg.Tasks {
 		// Validate the task does not reference undefined volume mounts
@@ -6484,6 +6492,15 @@ func (tg *TaskGroup) Validate(j *Job) error {
 			outer := fmt.Errorf("Task %s validation failed: %v", task.Name, err)
 			mErr.Errors = append(mErr.Errors, outer)
 		}
+
+		// Validate the group's Update Strategy does not conflict with the Task's kill_timeout for service type jobs
+		if isTypeService && tg.Update != nil {
+			if task.KillTimeout > tg.Update.ProgressDeadline {
+				mErr.Errors = append(mErr.Errors, fmt.Errorf("Task %s has a kill timout (%s) longer than the group's progress deadline (%s)",
+					task.Name, task.KillTimeout.String(), tg.Update.ProgressDeadline.String()))
+			}
+		}
+
 	}
 
 	return mErr.ErrorOrNil()