Skip to content

Commit

Permalink
docs: changelog entry for #5669 and fix comment
Browse files Browse the repository at this point in the history
  • Loading branch information
schmichael committed May 14, 2019
1 parent 796c05b commit abd809d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ __BACKWARDS INCOMPATIBILITIES:__
to update your code. [[GH-5536](https://github.com/hashicorp/nomad/pull/5536)]
* client: The format of check IDs in Consul has changed. If you rely upon
Nomad's check IDs you will need to update your code. [[GH-5536](https://github.com/hashicorp/nomad/pull/5536)]
* client: On startup a client will reattach to running tasks as before but
will not restart exited tasks. Exited tasks will be restarted only after the
client has reestablished communication with servers. System jobs will always
be restarted. [[GH-5669](https://github.com/hashicorp/nomad/pull/5669)]

FEATURES:

Expand Down
3 changes: 1 addition & 2 deletions client/allocrunner/taskrunner/task_runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,7 @@ type TaskRunner struct {
maxEvents int

// serversContactedCh is passed to TaskRunners so they can detect when
// servers have been contacted for the first time in case of a failed
// restore.
// GetClientAllocs has been called in case of a failed restore.
serversContactedCh <-chan struct{}

// waitOnServers defaults to false but will be set true if a restore
Expand Down

0 comments on commit abd809d

Please sign in to comment.