Ensure to close StreamFrame channel (#12248)

hashicorp · Mar 28, 2022 · 97dc687 · 97dc687
1 parent 167cfcd
commit 97dc687
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.changelog/12248.txt b/.changelog/12248.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+api: `AllocFS.Logs` now explicitly closes frames channel after being canceled
+```
diff --git a/api/fs.go b/api/fs.go
@@ -257,6 +257,7 @@ func (a *AllocFS) Logs(alloc *Allocation, follow bool, task, logType, origin str
 			// Check if we have been cancelled
 			select {
 			case <-cancel:
+				close(frames)
 				return
 			default:
 			}