Merge pull request #4355 from hashicorp/b-test-fixes

test fixes
hashicorp · May 30, 2018 · 4495ad9 · 4495ad9
2 parents 93e7dc8 + 51a5b59
commit 4495ad9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/command/agent/alloc_endpoint_test.go b/command/agent/alloc_endpoint_test.go
@@ -697,7 +697,7 @@ func TestHTTP_AllocAllGC(t *testing.T) {
 			s.server = srv
 		}
 
-		// no client, server resp
+		// client stats from server, should not error
 		{
 			c := s.client
 			s.client = nil
@@ -717,10 +717,7 @@ func TestHTTP_AllocAllGC(t *testing.T) {
 
 			respW := httptest.NewRecorder()
 			_, err = s.Server.ClientGCRequest(respW, req)
-			require.NotNil(err)
-
-			// The dev agent uses in-mem RPC so just assert the no route error
-			require.Contains(err.Error(), structs.ErrNoNodeConn.Error())
+			require.Nil(err)
 
 			s.client = c
 		}

diff --git a/command/agent/stats_endpoint_test.go b/command/agent/stats_endpoint_test.go
@@ -34,7 +34,7 @@ func TestClientStatsRequest(t *testing.T) {
 			}
 		}
 
-		// Local node, server resp
+		// client stats from server, should not error
 		{
 			srv := s.server
 			s.server = nil
@@ -70,11 +70,7 @@ func TestClientStatsRequest(t *testing.T) {
 
 			respW := httptest.NewRecorder()
 			_, err = s.Server.ClientStatsRequest(respW, req)
-			require.NotNil(err)
-
-			// The dev agent uses in-mem RPC so just assert the no route error
-			require.Contains(err.Error(), structs.ErrNoNodeConn.Error())
-
+			require.Nil(err)
 			s.client = c
 		}
 	})