Skip to content

Commit

Permalink
cli: Add var args to plan output. (#11631)
Browse files Browse the repository at this point in the history
  • Loading branch information
Liraim authored Dec 7, 2021
1 parent 6addbaf commit 2a8f032
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .changelog/11631.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
cli: Add `-var` and `-var-file` to the command line printed by `job plan`
```
17 changes: 13 additions & 4 deletions command/job_plan.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
const (
jobModifyIndexHelp = `To submit the job with version verification run:
nomad job run -check-index %d %s
nomad job run -check-index %d %s%s
When running the job with the check-index flag, the job will only be run if the
job modify index given matches the server-side version. If the index has
Expand Down Expand Up @@ -192,8 +192,17 @@ func (c *JobPlanCommand) Run(args []string) int {
return 255
}

runArgs := strings.Builder{}
for _, varArg := range varArgs {
runArgs.WriteString(fmt.Sprintf("-var=%q ", varArg))
}

for _, varFile := range varFiles {
runArgs.WriteString(fmt.Sprintf("-var-file=%q ", varFile))
}

exitCode := c.outputPlannedJob(job, resp, diff, verbose)
c.Ui.Output(c.Colorize().Color(formatJobModifyIndex(resp.JobModifyIndex, path)))
c.Ui.Output(c.Colorize().Color(formatJobModifyIndex(resp.JobModifyIndex, runArgs.String(), path)))
return exitCode
}

Expand Down Expand Up @@ -333,8 +342,8 @@ func getExitCode(resp *api.JobPlanResponse) int {

// formatJobModifyIndex produces a help string that displays the job modify
// index and how to submit a job with it.
func formatJobModifyIndex(jobModifyIndex uint64, jobName string) string {
help := fmt.Sprintf(jobModifyIndexHelp, jobModifyIndex, jobName)
func formatJobModifyIndex(jobModifyIndex uint64, args string, jobName string) string {
help := fmt.Sprintf(jobModifyIndexHelp, jobModifyIndex, args, jobName)
out := fmt.Sprintf("[reset][bold]Job Modify Index: %d[reset]\n%s", jobModifyIndex, help)
return out
}
Expand Down

0 comments on commit 2a8f032

Please sign in to comment.