Skip to content

Commit

Permalink
Do not fail when no docker registry auth is available
Browse files Browse the repository at this point in the history
this amends the behaviour introduced with #2651
and allows pulling public images when docker.auth.helper is set
  • Loading branch information
aep committed Jun 27, 2017
1 parent e9a55d9 commit 1699761
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion client/driver/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -1016,7 +1016,7 @@ func (d *DockerDriver) createImage(driverConfig *DockerDriverConfig, client *doc
func (d *DockerDriver) pullImage(driverConfig *DockerDriverConfig, client *docker.Client, repo, tag string) (id string, err error) {
authOptions, err := d.resolveRegistryAuthentication(driverConfig, repo)
if err != nil {
return "", fmt.Errorf("Failed to find docker auth for repo %q: %v", repo, err)
d.logger.Printf("[WARN] Failed to find docker auth for repo %q: %v", repo, err)
}

if authIsEmpty(authOptions) {
Expand Down

0 comments on commit 1699761

Please sign in to comment.