job parsing: fix panic when variable validation is missing condition (#…

…16018)
hashicorp · Feb 1, 2023 · 00d5749 · 00d5749
1 parent 67f8f22
commit 00d5749
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/.changelog/16018.txt b/.changelog/16018.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+parser: Fixed a panic in the job spec parser when a variable validation block was missing its condition
+```
diff --git a/jobspec2/types.variables.go b/jobspec2/types.variables.go
@@ -95,6 +95,17 @@ func (v *Variable) validateValue(val VariableAssignment) (diags hcl.Diagnostics)
 	for _, validation := range v.Validations {
 		const errInvalidCondition = "Invalid variable validation result"
 
+		if validation.Condition == nil {
+			diags = append(diags, &hcl.Diagnostic{
+				Severity:    hcl.DiagError,
+				Summary:     "Invalid variable validation specification",
+				Detail:      "validation requires a condition.",
+				Subject:     validation.DeclRange.Ptr(),
+				EvalContext: hclCtx,
+			})
+			continue
+		}
+
 		result, moreDiags := validation.Condition.Value(hclCtx)
 		diags = append(diags, moreDiags...)
 		if !result.IsKnown() {