Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Nested Pack updates #403

Merged
merged 27 commits into from
Sep 26, 2023
Merged

[feature] Nested Pack updates #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
2df7eb7
Reviewed feature work up to 33a3dd4
angrycub Sep 20, 2023
ec008e8
Simple changes from code review
angrycub Sep 5, 2023
cf2dbcc
Added missing parallelism to tests
angrycub Sep 5, 2023
e09a3b2
Simplify fixup funcs
angrycub Sep 5, 2023
1062988
Add comment for fixableDiags
angrycub Sep 5, 2023
b3d4bb4
Edit test fixture content
angrycub Sep 5, 2023
858c3ec
Make `_self` a constant
angrycub Sep 5, 2023
7667f84
Move convert behavior to variables package
angrycub Sep 5, 2023
509a4f5
Add `dynamic` type handling
angrycub Sep 5, 2023
222dd81
Add tests for formatters
angrycub Sep 5, 2023
6726d03
Add test for converting map of objects
angrycub Sep 6, 2023
bea5b66
Remove type aliasing; Use PackIDKeyedVarMap
angrycub Sep 8, 2023
2194fa2
Add comments and tests for packdiags package
angrycub Sep 8, 2023
0e06d69
Update Equal to be a pointer receiver
angrycub Sep 8, 2023
3a5dcb1
Add comments and tests to decoder package
angrycub Sep 12, 2023
ae28d7a
fmt.Errorf to errors.New when not a formatted error
angrycub Sep 12, 2023
28ecbfe
Fix typos in "creator" content
angrycub Sep 19, 2023
e409f2a
Add error information on Plan test
angrycub Sep 21, 2023
50d733a
Convert to stdlib slices package
angrycub Sep 22, 2023
11471d5
Remove unnecessary variables.Parser interface
angrycub Sep 22, 2023
0c2c514
dependentRenders -> dependencyRenders
angrycub Sep 22, 2023
81de760
Use pointer receiver on AsOverrideString
angrycub Sep 22, 2023
19eb8f0
Make pointer receivers where possible
angrycub Sep 22, 2023
1f0cad2
Update ParsedVariables comments
angrycub Sep 25, 2023
f52d540
Remove unnecessary funcs
angrycub Sep 25, 2023
1dc45e9
Fix Merge testcase
angrycub Sep 26, 2023
b80dfd4
Add casing around flaky test elements
angrycub Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 0 additions & 114 deletions fixtures/bad_pack/README.md
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions fixtures/bad_pack/metadata.hcl
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions fixtures/bad_pack/outputs.tpl
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions fixtures/bad_pack/templates/_helpers.tpl
View file
Open in desktop

This file was deleted.

81 changes: 0 additions & 81 deletions fixtures/bad_pack/templates/simple_service.nomad.tpl
View file
Open in desktop

This file was deleted.

132 changes: 0 additions & 132 deletions fixtures/bad_pack/variables.hcl
View file
Open in desktop

This file was deleted.

0 fixtures/connect.nomad → fixtures/jobspecs/connect.nomad
View file
Open in desktop
File renamed without changes.
0 fixtures/example-with-meta.nomad → fixtures/jobspecs/example-with-meta.nomad
View file
Open in desktop
File renamed without changes.
0 fixtures/example.nomad → fixtures/jobspecs/example.nomad
View file
Open in desktop
File renamed without changes.
0 fixtures/simple.nomad → fixtures/jobspecs/simple.nomad
View file
Open in desktop
File renamed without changes.
4 changes: 4 additions & 0 deletions fixtures/v1/simple_raw_exec_v1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Fixture: `simple_raw_exec_v1`

This pack is cloned in the Loader tests and broken in various ways to test
error handling
0 ...gistry/packs/simple_raw_exec/metadata.hcl → fixtures/v1/simple_raw_exec_v1/metadata.hcl
View file
Open in desktop
File renamed without changes.
0 ...egistry/packs/simple_raw_exec/outputs.tpl → fixtures/v1/simple_raw_exec_v1/outputs.tpl
View file
Open in desktop
File renamed without changes.
Loading