-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IND-369] TFE FDO on Nomad #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few comments for better user experience.
This is required for Optum customer who is looking for Nomad support for TFE. Please do the needful ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kkavish! I've left a bunch of comments but the major design issue I see here is the authentication to Nomad. If we're publishing a Pack for a service that talks to Nomad, we absolutely should be using the Task API and appropriate ACLs for it.
@tgross We are using the Nomad SDK with appropriate ACLs while interacting with Nomad inside TFE task. For ACLs, please search for If you meant to update the job definition to use |
Thanks @tgross! |
This is a pack to run TFE Flexible Deployment Option on Nomad.
It will take as an input the details of Nomad cluster already running and then try to start Terraform Enterprise container on it.
Please confirm the following if submitting a new pack:
New Pack Checklist
nomad-pack render <NAME>
nomad-pack plan <NAME>
nomad-pack runs <NAME>
Some screens: