Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add Initial Run #360

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

🚀 Add Initial Run #360

wants to merge 4 commits into from

Conversation

Pale-whale
Copy link

Description

This pr adds the ability to queue an initial run at the workspace creation
It adds two fields:

spec:
  initialRun: <true|false>
  initialRunType: <plan|apply>

I went with two variables because we often overrides helm variables and setting a value to false in a chart is easier than removing it completely.

I added functions to wait that the workspace is uploaded, variables too and a new run is needed and then start a new run. I have little to no experience in kubernetes operator development so it may be the wrong logic here.

Usage Example

spec:
  initialRun: true
  initialRunType: apply

Will queue an apply run when the workspace is created and all the variables are uploaded

References

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@Pale-whale Pale-whale requested a review from a team as a code owner March 1, 2024 14:27
@github-actions github-actions bot added documentation Improvements or additions to documentation crd helm-chart api golang controller labels Mar 1, 2024
@github-actions github-actions bot added the size/L label Mar 1, 2024
@baptman21
Copy link
Contributor

Thanks to the feature to trigger runs with an annotation (#364), we no longer need this PR. To have "an initial run", you may simply create the workspace with the annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Trigger a plan/apply on workspace creation
2 participants