Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HCP token endpoint #114

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Use HCP token endpoint #114

merged 2 commits into from
Aug 25, 2022

Conversation

tbalasavage
Copy link
Contributor

@tbalasavage tbalasavage commented Aug 23, 2022 •
edited
Loading

🛠️ Description

Changes the token endpoint from Auth0 to an endpoint on HCP.

🔗 External Links

Jira ticket
Relevant RFC section

🚢 Release Note

Release note for CHANGELOG:

BREAKING CHANGES:
* Change token endpoint from Auth0 to HCP

Definition of Done

  • Tests update
  • Tested locally

@tbalasavage
Copy link
Contributor Author

tbalasavage commented Aug 23, 2022 •
edited
Loading

I could use some help testing this outside of the unit tests just to be sure I've made all the necessary changes.
Ran as described below:

export HCP_CLIENT_ID=...
export HCP_CLIENT_SECRET=...
export HCP_ORGANIZATION_ID=...
export HCP_PROJECT_ID=...

go run ./cmd/hcp-sdk-go-client/main.go

@tbalasavage tbalasavage marked this pull request as ready for review August 24, 2022 15:52
@tbalasavage tbalasavage requested a review from a team August 24, 2022 15:52
bcmdarroch
bcmdarroch approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out with our other envs and it all checks out! 👍 👍

@bcmdarroch bcmdarroch merged commit 50dbf4d into main Aug 25, 2022
@bcmdarroch bcmdarroch deleted the hcpid-1244 branch August 25, 2022 20:50
@bcmdarroch bcmdarroch mentioned this pull request Aug 26, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcmdarroch bcmdarroch bcmdarroch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbalasavage @bcmdarroch