hcl: don't escape ANYTHING in ${}, let lower layer handle it #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
force-pushed
the
b-escape-interp
branch
from
ebac69e
to
62ebf93
Compare
|
Terraform 0.8 is upon us. Here we go. |
mitchellh
changed the title
This was referenced Nov 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 MERGE ONLY FOR TF 0.8 SINCE IT HAS BC-INCOMPAT 🚧
This changes the behavior of HCL to completely ignore any escape sequences within
${}. This is likely to break some configurations that used this. However, it resulted in more broken behavior if used with HIL.The prior behavior caused problems because HCL would escape some things (escaped backslashes) and then HIL would do the same, or error for syntax/unescaped reasons. This double escape caused most practical configs to not work at all.
This change is slated for Terraform 0.8 when we can introduce BC-incompat.