Merge pull request #576 from Mic92/improve-hclfmt

hclfmt: avoid rewrites when there are no changes in a file
hashicorp · Jan 30, 2023 · 938be77 · 938be77
2 parents 4557953 + 9e37c66
commit 938be77
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/cmd/hclfmt/main.go b/cmd/hclfmt/main.go
@@ -106,6 +106,7 @@ func processFiles() error {
 
 func processFile(fn string, in *os.File) error {
 	var err error
+	var hasLocalChanges bool = false
 	if in == nil {
 		in, err = os.Open(fn)
 		if err != nil {
@@ -131,10 +132,15 @@ func processFile(fn string, in *os.File) error {
 
 	if !bytes.Equal(inSrc, outSrc) {
 		changed = append(changed, fn)
+		hasLocalChanges = true
 	}
 
 	if *overwrite {
-		return ioutil.WriteFile(fn, outSrc, 0644)
+		if hasLocalChanges {
+			return ioutil.WriteFile(fn, outSrc, 0644)
+		} else {
+			return nil
+		}
 	}
 
 	_, err = os.Stdout.Write(outSrc)