Reflect that ref origins have multiple constraints #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-origin-constraints
branch
4 times, most recently
from
baeb761
to
63ecafb
Compare
radeksimko
force-pushed
the
f-origin-constraints
branch
from
63ecafb
to
454bfd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We collect origins and targets in parallel (not sequentially) and we cannot know which constraint would match the target if the origin has multiple constraints - such as in Terraform
resourceblocks havedepends_onwhich may contain multipleschema.TraversalExprwith differentScopeIds.Matching of the scope needs to be done only against decoded targets, not sooner.