Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support namespaced functions #372

Merged
merged 14 commits into from
Mar 26, 2024
Merged

feat: support namespaced functions #372

merged 14 commits into from
Mar 26, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Feb 8, 2024 •
edited
Loading

🚫 blocked until there's a new release of hcl/release with support for ExprSyntaxError:

hcl-lang/go.mod

Line 8 in 905e563

github.com/hashicorp/hcl/v2 v2.19.2-0.20240209134327-1e1a6b858a91

Closes hashicorp/vscode-terraform#1697

ansgarm
ansgarm commented Feb 8, 2024
View reviewed changes
schema/signature.go Outdated Show resolved Hide resolved
dbanck
dbanck reviewed Feb 15, 2024
View reviewed changes
schema/signature.go Outdated Show resolved Hide resolved
schema/signature.go Outdated Show resolved Hide resolved
@ansgarm ansgarm marked this pull request as ready for review February 15, 2024 12:58
@ansgarm ansgarm requested a review from a team as a code owner February 15, 2024 12:58
@ansgarm ansgarm requested a review from dbanck February 15, 2024 12:58
dbanck
dbanck requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, some minor suggestions.

Thanks for adding a namespaced function to the tests

schema/signature.go Show resolved Hide resolved
decoder/expr_function.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@ansgarm ansgarm force-pushed the f-provider-functions branch 2 times, most recently from 905e563 to 4b1e7ed Compare February 20, 2024 10:42
This was referenced Feb 23, 2024
Closed
Closed
ansgarm
ansgarm commented Mar 20, 2024
View reviewed changes
decoder/expr_function.go Outdated Show resolved Hide resolved
ansgarm
ansgarm commented Mar 20, 2024
View reviewed changes
decoder/expr_function.go Outdated Show resolved Hide resolved
@ansgarm ansgarm changed the title feat: add Detail to FunctionSignature and implement Copy() feat: support namespaced functions Mar 22, 2024
@ansgarm ansgarm requested a review from dbanck March 22, 2024 11:12
@dbanck dbanck merged commit 49d7378 into main Mar 26, 2024
5 checks passed
@dbanck dbanck deleted the f-provider-functions branch March 26, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completions: Recover partially typed provider defined functions after the first colon has been typed
2 participants
@ansgarm @dbanck