Adding Nomad packer template for Azure, updated versions

[errygg]

No description provided.

[bensojona]

NICE

I’m on my phone at the moment so can’t link to it, but there’s 2 more places that need to be updated when changing product versions in versions.sh - 1 in the README at the bottom (Image Version Table), and the other is the *_VERSIONS env vars at the bottom of versions.sh (so we can publish the images publicly).

[errygg]

Should I bump the RELEASE_VERSION as well?

[bensojona]

Yep!

On Wed, Aug 29, 2018 at 09:36 Erik R. Rygg ***@***.***> wrote: Should I bump the RELEASE_VERSION as well? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACUWasuTB7NUC4f_GFpo9DHzQJZG3V8Kks5uVqb0gaJpZM4WQboi> .

-- Jon

[bensojona]

Since they’re all OSS version you can set the map values to true as well and it will cut public images when you set RUN_PUBLISH to true and push a commit. RUN_BUILD needs to be true for the for CI to actually build the images - though you may need to add an Azure flag to Team city (I can help with that).

On Wed, Aug 29, 2018 at 10:53 Jon Benson ***@***.***> wrote: Yep! On Wed, Aug 29, 2018 at 09:36 Erik R. Rygg ***@***.***> wrote: > Should I bump the RELEASE_VERSION as well? > > — > You are receiving this because your review was requested. > > > Reply to this email directly, view it on GitHub > <#61 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACUWasuTB7NUC4f_GFpo9DHzQJZG3V8Kks5uVqb0gaJpZM4WQboi> > . > -- Jon

-- Jon

[errygg]

A thing I noticed when testing, I don't see the *-ent binaries in hc-enterprise-binaries s3 bucket. I modified the version to only reference the non-*-ent version. For example, s3://hc-enterprise-binaries/nomad-enterprise/ is where I found the enterprise binaries for Nomad.

[bensojona]

Hey Erik, you still need to add another version for NOMAD_VERSIONS as well (0.8.4), even if the version # hasn’t changed (each of the list lengths need to be the same).

Also - set the Boolean map for 0.1.4 in RELEASE_VERSIONS to ‘true’ so the AMIs get published publicly. Setting to ‘false’ keeps the AMIs private where you would need to add specific account IDs to access them. Since no enterprise binaries are placed on the AMIs, they can be publicly accessible for all. I can show you how to add account ids to private AMIs if you’d like to bake Enterprise AMIs as well.

Regarding where the ent binaries are - I’ll ping you.

[bensojona]

I’d still set the 0.1.4 RELEASE_VERSION map to true.

[bensojona]

Looks good, once you get the image building successfully in Azure, just flip RUN_BUILD back to false and merge to master. We don’t currently have a strategy for publishing Azure images publicly like we do for AMIs, we’ll need to investigate the proper way to do that.

[hashicorp-cla]

All committers have signed the CLA.