Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stacks vcs-repo encoding #964

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix Stacks vcs-repo encoding #964

merged 2 commits into from
Aug 23, 2024

Conversation

brandonc
Copy link
Collaborator

Description

There was a regression in terraform-provider-tfe after the last go-tfe bump which I narrowed down to this encoding change.

Testing plan

See test output below

Output from tests

Including output from tests may require access to a TFE instance. Ignore this section if you have no environment to test against.

$ OAUTH_CLIENT_GITHUB_TOKEN=$GITHUB_TOKEN ENABLE_BETA=1 go test ./... -v -run "TestWorkspacesCreateTableDriven/when_options_include_vcs-repo"
?       github.com/hashicorp/go-tfe/examples/backing_data       [no test files]
?       github.com/hashicorp/go-tfe/examples/configuration_versions     [no test files]
?       github.com/hashicorp/go-tfe/examples/registry_modules   [no test files]
?       github.com/hashicorp/go-tfe/examples/organizations      [no test files]
?       github.com/hashicorp/go-tfe/examples/run_errors [no test files]
?       github.com/hashicorp/go-tfe/examples/state_versions     [no test files]
?       github.com/hashicorp/go-tfe/examples/users      [no test files]
?       github.com/hashicorp/go-tfe/examples/workspaces [no test files]
?       github.com/hashicorp/go-tfe/mocks       [no test files]
=== RUN   TestWorkspacesCreateTableDriven
=== RUN   TestWorkspacesCreateTableDriven/when_options_include_vcs-repo
--- PASS: TestWorkspacesCreateTableDriven (8.21s)
    --- PASS: TestWorkspacesCreateTableDriven/when_options_include_vcs-repo (4.75s)
=== RUN   TestWorkspacesCreateTableDrivenWithGithubApp
    workspace_integration_test.go:476: Export a valid GITHUB_APP_INSTALLATION_ID before running this test!
--- SKIP: TestWorkspacesCreateTableDrivenWithGithubApp (0.00s)
PASS
ok      github.com/hashicorp/go-tfe     8.470s
$ OAUTH_CLIENT_GITHUB_TOKEN=$GITHUB_TOKEN ENABLE_BETA=1 go test ./... -v -run "TestStackReadUpdateDelete"
?       github.com/hashicorp/go-tfe/examples/backing_data       [no test files]
?       github.com/hashicorp/go-tfe/examples/configuration_versions     [no test files]
?       github.com/hashicorp/go-tfe/examples/organizations      [no test files]
?       github.com/hashicorp/go-tfe/examples/registry_modules   [no test files]
?       github.com/hashicorp/go-tfe/examples/run_errors [no test files]
?       github.com/hashicorp/go-tfe/examples/state_versions     [no test files]
?       github.com/hashicorp/go-tfe/examples/users      [no test files]
?       github.com/hashicorp/go-tfe/examples/workspaces [no test files]
?       github.com/hashicorp/go-tfe/mocks       [no test files]
=== RUN   TestStackReadUpdateDelete
--- PASS: TestStackReadUpdateDelete (6.50s)
PASS
ok      github.com/hashicorp/go-tfe     6.773s

image

Copy link
Contributor

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brandonc brandonc merged commit d0cc62d into main Aug 23, 2024
8 checks passed
@brandonc brandonc deleted the brandonc/fix_vcsrepo_encoding branch August 23, 2024 22:57
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants