Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump protoreflect to v1.15.1 #264

Merged
merged 1 commit into from
Aug 11, 2023
Merged

deps: bump protoreflect to v1.15.1 #264

merged 1 commit into from
Aug 11, 2023

Conversation

vancluever
Copy link
Contributor

This bumps protoreflect to v1.15.1, which should correct some long-running issues WRT downstream dependencies and protoreflect's use of grpc_testing, unblocking downstream dependencies from upgrading the grpc package again.

This bumps protoreflect to v1.15.1, which should correct some
long-running issues WRT downstream dependencies and protoreflect's use
of grpc_testing, unblocking downstream dependencies from upgrading the
grpc package again.
Copy link

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgrades to the v2 protobuf API, will this have any breaking change consequences on downstream packages?

@vancluever
Copy link
Contributor Author

@johanbrandhorst hard for me to say.

My fork is working in vancluever/terraform-provider-acme@50a0f94 and forward for passing tests (see https://github.com/vancluever/terraform-provider-acme/tree/64764c71c1188bb1c461112b021c49e272ac4c18), and my tests are working through a go-plugin implementation for DNS providers. For other things in the go-plugin ecosystem though, I don't currently have visibility on, unfortunately.

Copy link

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice step towards upgrading to the v2 API wholesale, but the consequences for the ecosystem is hard to predict. Maybe we can make a release candidate with this change before making a full release, to gauge any unintended impact?

@vancluever
Copy link
Contributor Author

@johanbrandhorst works for me! The ACME plugin is a pretty good isolated case and given my own testing, I think that combined with its stability within Terraform itself would be a pretty good test of how the larger ecosystem would fare.

@vancluever vancluever merged commit d61bc34 into hashicorp:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants