Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interrupting parent can result in orphaned plugins hot-looping #10

Closed
phinze opened this issue Feb 29, 2016 · 2 comments
Closed

Interrupting parent can result in orphaned plugins hot-looping #10

phinze opened this issue Feb 29, 2016 · 2 comments

Comments

@phinze
Copy link

phinze commented Feb 29, 2016

Filing this here so we can think about it:

hashicorp/terraform#5043 (comment)

Unfortunately we don't have repro, but we do have one user reporting it.
@phinze phinze mentioned this issue Feb 29, 2016
Closed
@mitchellh
Copy link
Contributor

Hm, a repro would help a lot. We don't double fork the plugins so when the parent dies, the plugins should also die. I can introduce a test case for this, but thats the behavior I've seen.

@mitchellh
Copy link
Contributor

Closing this until we see it again. Its been awhile :D

tomhjp added a commit that referenced this issue Oct 16, 2023
@tomhjp
# This is a combination of 10 commits.
60ad1da 
# This is the 1st commit message:

Add client option to multiplex gRPC broker connections over a single net.Conn

# The commit message #2 will be skipped:

# Checkpoint

# The commit message #3 will be skipped:

# Split muxer into client and server side

# The commit message #4 will be skipped:

# Fairly close, about to refactor muxers into internal package

# The commit message #5 will be skipped:

# Broken

# The commit message #6 will be skipped:

# Checkpoint, maybe not that far off but maybe a bit fucked

# The commit message #7 will be skipped:

# All but 4 tests passing

# The commit message #8 will be skipped:

# Extra debug in test

# The commit message #9 will be skipped:

# First iteration of blocked listener

# The commit message #10 will be skipped:

# Went pretty far with knocking concept. Ultimately though it's going to rely on something brittle, e.g. a connection that must live forever. Going to rip it out and drastically simplify with the restriction that you can only have one server on each side of the connection
tomhjp added a commit that referenced this issue Oct 16, 2023
@tomhjp
# This is a combination of 13 commits.
3f3bf80 
# This is the 1st commit message:

Add client option to multiplex gRPC broker connections over a single net.Conn

# The commit message #2 will be skipped:

# Checkpoint

# The commit message #3 will be skipped:

# Split muxer into client and server side

# The commit message #4 will be skipped:

# Fairly close, about to refactor muxers into internal package

# The commit message #5 will be skipped:

# Broken

# The commit message #6 will be skipped:

# Checkpoint, maybe not that far off but maybe a bit fucked

# The commit message #7 will be skipped:

# All but 4 tests passing

# The commit message #8 will be skipped:

# Extra debug in test

# The commit message #9 will be skipped:

# First iteration of blocked listener

# The commit message #10 will be skipped:

# Went pretty far with knocking concept. Ultimately though it's going to rely on something brittle, e.g. a connection that must live forever. Going to rip it out and drastically simplify with the restriction that you can only have one server on each side of the connection

# The commit message #11 will be skipped:

# lol j/k, implemented knocking over the existing streamer interface instead - not working yet

# The commit message #12 will be skipped:

# Fix some bugs, all tests passing except TestClient_reattachNotFound

# The commit message #13 will be skipped:

# Small bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitchellh @phinze