-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plugin package to be compiled under WASM #207
Conversation
(the builds are failing on 1.17 but are passing anyway because I think the |
Think you could fix the test? |
Sure, let me take a look at |
53e9ab5
to
cf1ab1c
Compare
@jefferai build and tests fixed and will actually fail now when appropriate :) |
Awesome thanks! I will defer to @johanbrandhorst on hitting Approve on this since I've not dealt with wasm and he knows a lot about it :-) |
Thanks! |
@jefferai would you mind merging? |
A couple of things... One -- I can't see any reason for the updates the various submodules that only contain go.mod/go.sum updates. Is there a reason, and if not, can they be reverted? Two -- not all tests are passing, is that expected? |
|
Note that it certainly doesn't *work* under WASM, but at least it should not cause compile errors.
Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
Thanks! |
Note that it certainly doesn't work under WASM, but at least it should not cause compile errors.