Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugin package to be compiled under WASM #207

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Conversation

swenson
Copy link
Contributor

@swenson swenson commented Nov 10, 2023

Note that it certainly doesn't work under WASM, but at least it should not cause compile errors.

@swenson swenson requested review from jefferai and a team as code owners November 10, 2023 18:45
@swenson
Copy link
Contributor Author

swenson commented Nov 10, 2023

(the builds are failing on 1.17 but are passing anyway because I think the find is hiding the error code?)

@jefferai
Copy link
Member

Think you could fix the test?

@swenson
Copy link
Contributor Author

swenson commented Nov 13, 2023

Sure, let me take a look at find and see if I can fix it.

@swenson
Copy link
Contributor Author

swenson commented Nov 13, 2023

@jefferai build and tests fixed and will actually fail now when appropriate :)

@jefferai
Copy link
Member

Awesome thanks! I will defer to @johanbrandhorst on hitting Approve on this since I've not dealt with wasm and he knows a lot about it :-)

.github/workflows/go.yml Show resolved Hide resolved
.github/workflows/go.yml Show resolved Hide resolved
@swenson
Copy link
Contributor Author

swenson commented Nov 15, 2023

Thanks!

@swenson
Copy link
Contributor Author

swenson commented Nov 15, 2023

@jefferai would you mind merging?

@jefferai
Copy link
Member

A couple of things...

One -- I can't see any reason for the updates the various submodules that only contain go.mod/go.sum updates. Is there a reason, and if not, can they be reverted?

Two -- not all tests are passing, is that expected?

@swenson
Copy link
Contributor Author

swenson commented Nov 17, 2023

@jefferai

  1. hashicorp/go-sockaddr >=1.0.6 is needed to compile to WASM (that is the release after I did Add support for js/wasm go-sockaddr#55)

  2. The only test that isn't passing is buf_if_merged, and I honestly haven't investigated what that test is. It appears to be misconfigured (missing token?).

@jefferai jefferai merged commit d528673 into hashicorp:main Nov 20, 2023
19 checks passed
@swenson swenson deleted the wasm branch November 20, 2023 18:35
@swenson
Copy link
Contributor Author

swenson commented Nov 20, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants