Prevent Git Config Alteration on Git Update #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduzgun-security
requested review from
radeksimko,
eastebry,
liamcervante and
mcollao-hc
eastebry
approved these changes
Jun 20, 2024
liamcervante
approved these changes
Jun 21, 2024
renovate bot
referenced
this pull request
in jippi/dottie
Jun 24, 2024
…go.mod (#58) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/hashicorp/go-getter](https://togithub.com/hashicorp/go-getter) | `v1.7.4` -> `v1.7.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>hashicorp/go-getter (github.com/hashicorp/go-getter)</summary> ### [`v1.7.5`](https://togithub.com/hashicorp/go-getter/releases/tag/v1.7.5) [Compare Source](https://togithub.com/hashicorp/go-getter/compare/v1.7.4...v1.7.5) #### What's Changed - Prevent Git Config Alteration on Git Update by [@​dduzgun-security](https://togithub.com/dduzgun-security) in [https://github.com/hashicorp/go-getter/pull/497](https://togithub.com/hashicorp/go-getter/pull/497) #### New Contributors - [@​dduzgun-security](https://togithub.com/dduzgun-security) made their first contribution in [https://github.com/hashicorp/go-getter/pull/497](https://togithub.com/hashicorp/go-getter/pull/497) **Full Changelog**: hashicorp/go-getter@v1.7.4...v1.7.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nywilken
added a commit
that referenced
this pull request
Jun 28, 2024
](https://renovatebot.com){kind=link}
nywilken
added a commit
that referenced
this pull request
Jul 23, 2024
* Recreate git config during update to prevent git config alteration Backport fix from #497 to v2 * Bump version of Golang container to match module version The Go module for v2 is 1.19, bumping the base docker image to match the minimum version ensures go-getter can be compiled and executed on the container. This change resolves the failing acceptance test for Samba. ``` Run docker exec -i gogetter bash -c "env ACC_SMB_TEST=1 go test -v ./... -run=TestSmb_" docker exec -i gogetter bash -c "env ACC_SMB_TEST=1 go test -v ./... -run=TestSmb_" shell: /usr/bin/bash -e {0} env: TEST_RESULTS_PATH: /tmp/test-results Error: ./get_git.go:366:16: undefined: os.ReadDir Error: ./get_git_test.go:886:9: undefined: os.WriteFile Error: ./get_git_test.go:904:22: undefined: os.ReadFile note: module requires Go 1.19 FAIL github.com/hashicorp/go-getter/v2 [build failed] ? github.com/hashicorp/go-getter/v2/helper/testing [no test files] testing: warning: no tests to run PASS ok github.com/hashicorp/go-getter/v2/helper/url 0.006s [no tests to run] FAIL Error: Process completed with exit code 2. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreate git config during update to prevent git config alteration