s3: Force setting region always in AWS session #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobenolt
commented
Aug 12, 2021
| // location, so we need to override and explicitly bind what region we're | ||
| // intending based on the bucket location otherwise it's possible to get | ||
| // a MissingRegion error. | ||
| if region != "" { |
There was a problem hiding this comment.
I didn't want to make this change since I didn't look that deep, but I think we can avoid this check entirely since afaict, this value will always be something. Any detection of region that gets passed in here comes through at least with a fallback of us-east-1 when there's no region defined in the url itself. But I kept it since it existed in getAWSConfig before.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I describe the problem in comment in code, but tl;dr is when using
?aws_profile=xxxmethod, we never setregionon the AWS session unless it's defined in the profile itself. This is incorrect behavior since buckets exist in different regions than your profile and are explicitly defined anyways.Without this, in my case, I was getting a
MissingRegionerror when callingclient.GetObject().