Add support to detect 5 parts s3 virtual hosted-style requests #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ericdong66
force-pushed
the
fix-detect-s3
branch
from
e571d6d to
e704f62
Compare
|
This PR allows Nomad to download S3 artifacts using the AWS recommended 5 part virtual-host pattern. Looking for a repo maintainer to review/merge. |
tgross
approved these changes
Apr 29, 2021
azr
reviewed
Apr 29, 2021
| @@ -59,3 +61,13 @@ func (d *S3Detector) detectVhostStyle(region, bucket string, parts []string) (st | |||
|
|
|||
| return "s3::" + url.String(), true, nil | |||
| } | |||
|
|
|||
| func (d *S3Detector) detectNewVhostStyle(region, bucket string, parts []string) (string, bool, error) { | |||
There was a problem hiding this comment.
NIT: I wonder what the new, new name will be if AWS adds a new 6 parts vhost-style url
This was referenced Jun 17, 2021
1 task
This was referenced Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looking at aws doc
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#virtual-hosted-style-access
the new s3 virtual hosted-style has 5 hostParts
https://bucket-name.s3.Region.amazonaws.com/key-name
this PR is to enhance the S3Detector, so it recognize this new s3 style.