Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link in support for the tarDecompressor, so it can be used on .tar files #138

Merged
merged 1 commit into from
Jun 29, 2021
Merged

link in support for the tarDecompressor, so it can be used on .tar files #138

merged 1 commit into from
Jun 29, 2021

Conversation

ketzacoatl
Copy link
Contributor

resolve #19.

@aaronhurt
Copy link

LGTM ... this should work. I think it makes sense to go ahead and export tarDecompressor as TarDecompressor for consistency.

@ketzacoatl
Copy link
Contributor Author

ketzacoatl commented Dec 13, 2018 •
edited
Loading

@leprechau would that be as simple as renaming https://github.com/hashicorp/go-getter/blob/master/decompress_tar.go#L138-L142 (and the reference in my PR), or is there more to do to export the TarDecompressor correctly?

Other references to tarDecompressor, across the code base, would need that update too, right?

@ketzacoatl
Copy link
Contributor Author

This ought to make it easier to resolve hashicorp/nomad#2443.

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 6, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mdeggies mdeggies changed the base branch from master to main October 23, 2020 00:54
schmichael
schmichael approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this fell through the cracks. Merging and can export tarDecompressor in a followup. Doing so here would require resolving a merge conflict.

@schmichael schmichael merged commit 04c5139 into hashicorp:main Jun 29, 2021
schmichael added a commit that referenced this pull request Jun 29, 2021
@schmichael
export tar decompressor
6a2a051 
Asked for in #19, added in #138, and now exported to match others
@schmichael schmichael mentioned this pull request Jun 29, 2021
Merged
@ketzacoatl
Copy link
Contributor Author

Yay! Thanks @schmichael!

@tgross tgross mentioned this pull request Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmichael schmichael schmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for tar archives
4 participants
@ketzacoatl @aaronhurt @hashicorp-cla @schmichael