-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to go 1.17 and fix CVEs #230
Conversation
e29f116
to
24d773c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tysm
) | ||
|
||
go 1.14 | ||
go 1.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to go to 1.19 since 1.17 is no longer supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to do too many jumps in Go versions. It is probably "ok" though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call that makes sense
minor comment, otherwise LGTM |
Fixing several CVEs in the package. This also required an upgrade to Go 1.17
CVEs are below:
GO-2022-0969 in golang.org/x/[email protected]
GHSA-vvpx-j8f3-3w6h in golang.org/x/[email protected]
GHSA-8cfg-vx93-jvxw in k8s.io/[email protected]
GO-2022-1144 in golang.org/x/[email protected]
GHSA-f5pg-7wfw-84q9 in github.com/aws/[email protected]
GHSA-44r7-7p62-q3fr in github.com/miekg/[email protected]
GHSA-h86h-8ppg-mxmh in golang.org/x/[email protected]
GHSA-76wf-9vgp-pj7w in github.com/aws/[email protected]
GO-2021-0064 in k8s.io/[email protected]
GO-2022-0236 in golang.org/x/[email protected]
GO-2022-0391 in github.com/aws/[email protected]
GHSA-69cg-p879-7622 in golang.org/x/[email protected]
GHSA-83g2-8m93-v3w7 in golang.org/x/[email protected]
GHSA-7f33-f4f5-xwgw in github.com/aws/[email protected]
GO-2023-1571 in golang.org/x/[email protected]
GO-2020-0008 in github.com/miekg/[email protected]
GO-2021-0238 in golang.org/x/[email protected]
GO-2022-0288 in golang.org/x/[email protected]
GHSA-gwc9-m7rh-j2ww in golang.org/x/[email protected]
GO-2021-0053 in github.com/gogo/[email protected]
GO-2022-0968 in golang.org/x/[email protected]
GHSA-p782-xgp4-8hr8 in golang.org/x/[email protected]
GHSA-c3h9-896r-86jm in github.com/gogo/[email protected]
GO-2021-0356 in golang.org/x/[email protected]
GO-2021-0113 in golang.org/x/[email protected]
GO-2020-0015 in golang.org/x/[email protected]
GHSA-69ch-w2m2-3vjp in golang.org/x/[email protected]
GHSA-8c26-wmh5-6g9v in golang.org/x/[email protected]
GO-2022-1059 in golang.org/x/[email protected]
GO-2021-0227 in golang.org/x/[email protected]
GHSA-3vm4-22fp-5rfm in golang.org/x/[email protected]
GO-2022-0493 in golang.org/x/[email protected]
GHSA-ppp9-7jff-5vj2 in golang.org/x/[email protected]
CVE-2020-14040 in golang.org/x/[email protected]
CVE-2021-38561 in golang.org/x/[email protected]
CVE-2022-32149 in golang.org/x/[email protected]
CVE-2020-8911 in github.com/aws/[email protected]
CVE-2020-8912 in github.com/aws/[email protected]
CVE-2022-2582 in github.com/aws/[email protected]