Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Modules Part 2 - resource-manager/ #843

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jan 24, 2024

This PR is part 2 of adding Nested Go Modules - adding the ./resource-manager/ Go Module.

Once merged this likely wants to be manually released first - at which point we should be able to re-enable the automation.

Part of hashicorp/pandora#3601

Note: The Go Module path for the Base Layer needs updating. Done

Dependent on #842

@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Jan 24, 2024
@tombuildsstuff tombuildsstuff force-pushed the f/submodules-2-resource-manager branch 2 times, most recently from b4ddd05 to f299a0c Compare January 24, 2024 17:16
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending the go.mod TODO, this LGTM 👍

@tombuildsstuff tombuildsstuff force-pushed the f/submodules-2-resource-manager branch from f299a0c to 8802ea2 Compare January 25, 2024 10:22
@tombuildsstuff tombuildsstuff marked this pull request as ready for review January 25, 2024 10:22
@tombuildsstuff tombuildsstuff requested a review from a team as a code owner January 25, 2024 10:22
@tombuildsstuff tombuildsstuff merged commit 15b6d24 into main Jan 25, 2024
3 checks passed
@tombuildsstuff tombuildsstuff deleted the f/submodules-2-resource-manager branch January 25, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants