SDK tweaks

[manicminer]

• Environments: tidy up endpoints and resource identifiers
• Environments: try to support environments with older schemas like USGovernment which has reverted to an older ARM Metadata schema version (see below)
• Claims: should not be an internal package
• Auth: export the tenant ID when using CLI authentication, as it is auto detected when unspecified
• Add Microsoft Graph base client

On failure to parse metadata, debug logs should contain the metadata response for troubleshooting purposes

/opt/homebrew/Cellar/go/1.19.5/libexec/bin/go tool test2json -t /private/var/folders/24/xsk_v43x59j9gvchfjp91j7w0000gq/T/GoLand/___endpoint_refresh_test_go.test -test.v -test.paniconexit0 -test.run ^\QTestEndpointRefresh_China\E|\QTestEndpointRefresh_Public\E|\QTestEndpointRefresh_USGovernment\E$
=== RUN   TestEndpointRefresh_China
--- PASS: TestEndpointRefresh_China (7.66s)
=== RUN   TestEndpointRefresh_Public
--- PASS: TestEndpointRefresh_Public (0.93s)
=== RUN   TestEndpointRefresh_USGovernment
2023/02/02 12:29:15 [DEBUG] Unrecognised metadata response for https://management.usgovcloudapi.net/metadata/endpoints?api-version=2022-09-01: [{"portal":"https://portal.azure.com","authentication":{"loginEndpoint":"https://login.microsoftonline.com/","audiences":["https://management.core.windows.net/","https://management.azure.com/"],"tenant":"common","identityProvider":"AAD"},"media":"https://rest.media.azure.net","graphAudience":"https://graph.windows.net/","graph":"https://graph.windows.net/","name":"AzureCloud","suffixes":{"azureDataLakeStoreFileSystem":"azuredatalakestore.net","acrLoginServer":"azurecr.io","sqlServerHostname":"database.windows.net","azureDataLakeAnalyticsCatalogAndJob":"azuredatalakeanalytics.net","keyVaultDns":"vault.azure.net","storage":"core.windows.net","azureFrontDoorEndpointSuffix":"azurefd.net"},"batch":"https://batch.core.windows.net/","resourceManager":"https://management.azure.com/","vmImageAliasDoc":"https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-compute/quickstart-templates/aliases.json","activeDirectoryDataLake":"https://datalake.azure.net/","sqlManagement":"https://management.core.windows.net:8443/","gallery":"https://gallery.azure.com/"},{"portal":"https://portal.azure.cn","authentication":{"loginEndpoint":"https://login.chinacloudapi.cn","audiences":["https://management.core.chinacloudapi.cn","https://management.chinacloudapi.cn"],"tenant":"common","identityProvider":"AAD"},"media":"https://rest.media.chinacloudapi.cn","graphAudience":"https://graph.chinacloudapi.cn","graph":"https://graph.chinacloudapi.cn","name":"AzureChinaCloud","suffixes":{"acrLoginServer":"azurecr.cn","sqlServerHostname":"database.chinacloudapi.cn","keyVaultDns":"vault.azure.cn","storage":"core.chinacloudapi.cn","azureFrontDoorEndpointSuffix":""},"batch":"https://batch.chinacloudapi.cn","resourceManager":"https://management.chinacloudapi.cn","vmImageAliasDoc":"https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-compute/quickstart-templates/aliases.json","sqlManagement":"https://management.core.chinacloudapi.cn:8443","gallery":"https://gallery.chinacloudapi.cn"},{"portal":"https://portal.azure.us","authentication":{"loginEndpoint":"https://login.microsoftonline.us","audiences":["https://management.core.usgovcloudapi.net","https://management.usgovcloudapi.net"],"tenant":"common","identityProvider":"AAD"},"media":"https://rest.media.usgovcloudapi.net","graphAudience":"https://graph.windows.net","graph":"https://graph.windows.net","name":"AzureUSGovernment","suffixes":{"acrLoginServer":"azurecr.us","sqlServerHostname":"database.usgovcloudapi.net","keyVaultDns":"vault.usgovcloudapi.net","storage":"core.usgovcloudapi.net","azureFrontDoorEndpointSuffix":""},"batch":"https://batch.core.usgovcloudapi.net","resourceManager":"https://management.usgovcloudapi.net","vmImageAliasDoc":"https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-compute/quickstart-templates/aliases.json","sqlManagement":"https://management.core.usgovcloudapi.net:8443","gallery":"https://gallery.usgovcloudapi.net"}]
2023/02/02 12:29:15 [DEBUG] Falling back to ARM Metadata version 2019-05-01 for https://management.usgovcloudapi.net
--- PASS: TestEndpointRefresh_USGovernment (3.11s)
PASS

[tombuildsstuff]

Left a few comments inline but otherwise 👍

[tombuildsstuff]

should we be exposing EnableRetries if it does nothing at this point?

[manicminer]

Each service client will pass in its own retryfunc since the conditions for retrying are subtly different between endpoints, so this will take affect as clients are built.

[tombuildsstuff]

ah ok - is it worth the constructor taking a RetryPolicy (or rather an interface, which returns it) then?

func NewMsGraphClient(api environments.Api, apiVersion ApiVersion, tenantId string, retryConfiguration RetryConfiguration) (*Client, error) {
      // ..
}

type RetryConfiguration interface {
  RetryPolicy() []client.RequestRetryFunc
}

That'd allow us to offer some default retry policies, but also override that as needed?

[manicminer]

I like that, although this would also need to be different per method. For example, the retry conditions for creating a service principal are different to getting a service principal. At the moment the RetryFuncs are stored in the Request object, with the client deciding whether or not to use them.