Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK: Adjust client RetryMax to not exceed timeout #1072

Merged
merged 1 commit into from
Sep 25, 2024
Merged

SDK: Adjust client RetryMax to not exceed timeout #1072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions sdk/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,14 +692,28 @@ func (c *Client) retryableClient(ctx context.Context, checkRetry retryablehttp.C
r.RetryWaitMin = 1 * time.Second
r.RetryWaitMax = 61 * time.Second

// The default backoff results into the following formula T(n):
// ("t" repr. total time in sec, "n" repr. total retry count):
// - t = 2**(n+1) - 1 (0<=n<6)
// - t = (1+2+4+8+16+32) + 61*(n-6) (n>6)
// This results into the following N(t) (by guaranteeing T(n) <= t):
// - n = floor(log(t+1)) - 1 (0<=t<=63)
// - n = (t - 63)/61 + 6 (t > 63)
var safeRetryNumber = func(t time.Duration) int {
sec := t.Seconds()
if sec <= 63 {
return int(math.Floor(math.Log2(sec+1))) - 1
}
return (int(sec)-63)/61 + 6
}

// Default RetryMax of 16 takes approx 10 minutes to iterate
r.RetryMax = 16

// Extend the RetryMax if the context timeout exceeds 10 minutes
// In case the context has deadline defined, adjust the retry count to a value
// that the total time spent for retrying is right before the deadline exceeded.
if deadline, ok := ctx.Deadline(); ok {
if timeout := deadline.Sub(time.Now()); timeout > 10*time.Minute {
r.RetryMax = int(math.Round(timeout.Minutes())) + 6
}
r.RetryMax = safeRetryNumber(deadline.Sub(time.Now()))
}

tlsConfig := tls.Config{
Expand Down
Loading