Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use CGO with arm build (fixes go bug) #228

Merged
merged 1 commit into from
Jan 8, 2020
Merged

use CGO with arm build (fixes go bug) #228

merged 1 commit into from
Jan 8, 2020

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Dec 18, 2019

Build all arm binaries with CGO enabled to address golang bug..

golang/go#32912

Includes arm64 to standardize the platforms supported with those
consul-template supports.

Fixes #227

@eikenb
use CGO with arm build (fixes go bug)
b7299a7 
Build all arm binaries with CGO enabled to address golang bug..

golang/go#32912

Includes arm64 to standardize the platforms supported with those
consul-template supports.

Fixes #227
@eikenb eikenb added the bug label Dec 18, 2019
@eikenb eikenb added this to the 0.9.2 milestone Dec 18, 2019
@eikenb eikenb requested a review from a team December 18, 2019 23:37
lornasong
lornasong reviewed Dec 19, 2019
View reviewed changes
Copy link
Member

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Just asking some initial questions to help me better understand so I can be thoughtful about reviewing.

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
docker/pristine/Dockerfile Show resolved Hide resolved
@eikenb eikenb requested a review from lornasong January 7, 2020 22:30
lornasong
lornasong approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@lornasong lornasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! thanks for answering all my questions and all the context!

@eikenb eikenb merged commit 02e79e2 into master Jan 8, 2020
@eikenb eikenb deleted the issue-227-arm-cgo-build branch January 8, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornasong lornasong lornasong approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.9.2
Development

Successfully merging this pull request may close these issues.

Build Arm binaries with CGO enabled
2 participants
@eikenb @lornasong