Added /etc/nsswitch.conf file so container's hosts file is respected by Consul - fixes #94 #95
Conversation
0.X/Dockerfile
Outdated
| @@ -46,6 +46,10 @@ RUN mkdir -p /consul/data && \ | |||
| mkdir -p /consul/config && \ | |||
| chown -R consul:consul /consul | |||
|
|
|||
| # set up nsswitch.conf for Go's "netgo" implementation which is used by Consul, | |||
| # otherwise DNS supercedes the container's hosts file, which we don't want. | |||
| RUN [ ! -e /etc/nsswitch.conf ] && echo 'hosts: files dns' > /etc/nsswitch.conf | |||
There was a problem hiding this comment.
Wont this eval to a non-zero exit code if for some reason a newer alpine were to include an nsswitch.conf
I think it would be better as RUN test -e /etc/nsswitch.conf || echo 'hosts: files dns' > /etc/nsswitch.conf that way the only way the command fails is if nsswitch.conf didn't exist and wasn't created.
|
Ah yes, good catch. |
|
For some more context: When an nsswitch.conf file isn't present on linux, the Go runtime defaults to a hosts nss configuration that should be equivalent to "dns [!UNAVAIL=return] files". This is pretty undesirable as if the upstream DNS responds with NXDOMAIN then that response gets returned without checking the hosts file. This pr adds an nsswitch.conf file to the image that will change the ordering to check files first and then DNS. |
The image did not include
/etc/nsswitch.conf, and so hostname resolution was using DNS before checking/etc/hosts. This commit fixes that.See #94