-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish types from packages/components
#2004
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
also blueprint is missing this dep which I had to install manually 681ac01 |
What is that used for/how do we know we need it? Just curious as checks seem to be ✅ without |
@aklkv thanks for the example usage, I'm still not certain on how to know that we need that? If it's necessary, it makes me wonder if we're missing something in our checks that would signal that to us |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the refactor in #2004 the HDS code fails in `atlas` with
📌 Summary
The main issue this PR attempts to fix is the lack of type declarations being produced for the components package.
The impact of no type declarations is consumers get no type information, and do not get type checking when using components from this package.
Two steps to resolve this:
📸 Screenshots
In
packages/components
:yarn
yarn build
Build should succeed and you should see a declarations folder (adjacent to dist) with type declarations
In
showcase
(important: after doing the above):yarn
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.