Revert #59 #103
Merged
Revert #59 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-ju
requested review from
a team,
dekimsey and
dlaguerta
and removed request for
a team
dlaguerta
approved these changes
Nov 28, 2023
|
Created this ticket to (hopefully) come back to fixing the whitespace issues with Ember templating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
The change introduced in #59 caused Babel to leave endless traces of error across our products (I encounter them on a regular basis in
nomad,vault,design-system,cloud-ui).The error is always the same
The root cause is in
ember-template-compiler, as mentioned in #59 (comment) but until that gets sorted (if it ever gets sorted) we should be preserving the non-white-space-trimming syntax.I understand this format may have side effects in whitespace-sensitive templates, but these isolated cases can be addressed individually, rather than leaving long traces of compiler errors.
Leaving this here for your consideration.
👍 Definition of Done
🤔 Can be merged upon approval?
✅