Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TLS cert creation instruction for Consul federation #9838

Merged
merged 4 commits into from
Mar 3, 2021
Merged

Fix TLS cert creation instruction for Consul federation #9838

merged 4 commits into from
Mar 3, 2021

Conversation

Ranjandas
Copy link
Contributor

The Consul Federation requires the Server nodes to have an additional SAN entry of the form <node_name>.server.<dc>.<domain>. This was missing from the instructions for K8S to VM federation.

  • Updated the instructions and CLI example
  • Fixed numbering

Ranjandas added 2 commits March 2, 2021 09:39
@Ranjandas
Update cert creation instruction for Federation
9c74d6c 
The Server certificates used for Federation require the node name in the form of `<node>.server.<dc>.<domain>`. Not having this would through `bad tls certificate` error.

* Fixed cert create command
* Added note to create a wildcard cert (like the ones on Kubernetes)
* Fixed numbering
@Ranjandas
Added references to node name
479d6e6
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 1, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging March 1, 2021 22:50 Inactive
@Ranjandas Ranjandas requested review from lkysow and removed request for thisisnotashwin March 1, 2021 22:50
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@Ranjandas Ranjandas added type/docs Documentation needs to be created/updated/clarified type/docs-cherrypick labels Mar 1, 2021
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging March 1, 2021 23:20 Inactive
@Ranjandas Ranjandas added the pr/no-changelog PR does not need a corresponding .changelog entry label Mar 1, 2021
lkysow
lkysow approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Should you provide an example of the error when you don't pass -node?

@Ranjandas
Copy link
Contributor Author

Looks great!

Should you provide an example of the error when you don't pass -node?

Thank you for reviewing. Sure, will update the doc with the error message.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging March 2, 2021 01:41 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging March 2, 2021 01:48 Inactive
@Ranjandas Ranjandas requested a review from lkysow March 2, 2021 01:53
@Ranjandas
Copy link
Contributor Author

@lkysow If you are happy with the change (added error message), I will merge the PR (provided I have access to merge).

@lkysow
Copy link
Member

lkysow commented Mar 2, 2021

Looks great!

@lkysow
Copy link
Member

lkysow commented Mar 2, 2021

lmk if you can't merge

@Ranjandas Ranjandas merged commit 86b2a2b into hashicorp:master Mar 3, 2021
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/342092.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 86b2a2b onto stable-website succeeded!

hashicorp-ci pushed a commit that referenced this pull request Mar 24, 2021
@Ranjandas @hashicorp-ci
Merge pull request #9838 from Ranjandas/master
c922403 
Fix TLS cert creation instruction for Consul federation
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 86b2a2b onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Mar 24, 2021
@Ranjandas @hashicorp-ci
Merge pull request #9838 from Ranjandas/master
ee93193 
Fix TLS cert creation instruction for Consul federation
dizzyup pushed a commit that referenced this pull request Apr 21, 2021
@Ranjandas @dizzyup
Merge pull request #9838 from Ranjandas/master
4a0a075 
Fix TLS cert creation instruction for Consul federation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkysow lkysow Awaiting requested review from lkysow

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ranjandas @hashicorp-cla @hashicorp-ci @lkysow