Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs describing migrating to CRDs #9562

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Jan 14, 2021

  • Document how users can migrate to CRDs.
  • Update documentation for federation with new ProxyDefaults
    requirement.
  • Ensure controller.enabled: true is set in our example configs.
  • Remove connect-service-protocol annotation docs.

⚠️ must be merged after consul-helm release ⚠️

@lkysow lkysow added type/docs Documentation needs to be created/updated/clarified type/docs-cherrypick labels Jan 14, 2021
* Document how users can migrate to CRDs.
* Update documentation for federation with new `ProxyDefaults`
requirement.
* Ensure `controller.enabled: true` is set in our example configs.
* Remove `connect-service-protocol` annotation docs.
@lkysow lkysow force-pushed the lkysow/crd-upgrade-docs branch from 949063a to 83e43fc Compare January 25, 2021 21:43
@vercel
Copy link

vercel bot commented Jan 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

consul-ui-staging – ./ui

🔍 Inspect: https://vercel.com/hashicorp/consul-ui-staging/4pcsip1rf
✅ Preview: Canceled

[Deployment for 9ab41ed canceled]

@lkysow lkysow requested review from a team, ndhanushkodi and thisisnotashwin and removed request for a team January 25, 2021 21:44
@lkysow lkysow marked this pull request as ready for review January 25, 2021 21:44
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just had some clarifying questions!

Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the documentations here Luke! It is most excellent!!

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging January 29, 2021 19:30 Inactive
@thisisnotashwin thisisnotashwin merged commit 2df91c2 into master Feb 17, 2021
@thisisnotashwin thisisnotashwin deleted the lkysow/crd-upgrade-docs branch February 17, 2021 19:01
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/328714.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 2df91c2 onto stable-website succeeded!

hashicorp-ci pushed a commit that referenced this pull request Feb 17, 2021
* Document how users can migrate to CRDs.
* Update documentation for federation with new `ProxyDefaults`
requirement.
* Ensure `controller.enabled: true` is set in our example configs.
* Remove `connect-service-protocol` annotation docs.
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 2df91c2 onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Feb 17, 2021
* Document how users can migrate to CRDs.
* Update documentation for federation with new `ProxyDefaults`
requirement.
* Ensure `controller.enabled: true` is set in our example configs.
* Remove `connect-service-protocol` annotation docs.
dizzyup pushed a commit that referenced this pull request Apr 21, 2021
* Document how users can migrate to CRDs.
* Update documentation for federation with new `ProxyDefaults`
requirement.
* Ensure `controller.enabled: true` is set in our example configs.
* Remove `connect-service-protocol` annotation docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants