Display a security warning when enable_scripts_checks is enabled without security #7437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @i0rek |
pierresouchay
changed the title
pierresouchay
force-pushed
the
security_warnings_for_security_issues
branch
3 times, most recently
from
0c9d411 to
65f8ff7
Compare
|
LGTM |
pierresouchay
force-pushed
the
security_warnings_for_security_issues
branch
2 times, most recently
from
4b42260 to
0fcd120
Compare
|
unstable integration test, force-pushing to fix... |
pierresouchay
force-pushed
the
security_warnings_for_security_issues
branch
3 times, most recently
from
8c6c585 to
3cc86a3
Compare
hanshasselberg
requested changes
Apr 1, 2020
hanshasselberg
added
the
waiting-reply
…out security In order to enforce a bit security on Consul agents, add a new method in agent to highlight possible security issues. This does not return an error for now, but might in the future. For now, it detects issues such as: https://www.hashicorp.com/blog/protecting-consul-from-rce-risk-in-specific-configurations/ This would display this kind of messages: ``` 2020-03-11T18:27:49.873+0100 [ERROR] agent: [SECURITY] issue: error="using enable-script-checks without ACLs and without allow_write_http_from is DANGEROUS, use enable-local-script-checks instead see https://www.hashicorp.com/blog/protecting-consul-from-rce-risk-in-specific-configurations/" ```
pierresouchay
force-pushed
the
security_warnings_for_security_issues
branch
from
3cc86a3 to
98ef7b0
Compare
@i0rek DONE, added unit test |
ghost
removed
waiting-reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enforce a bit security on Consul agents, add a new method in agent
to highlight possible security issues.
This does not return an error for now, but might in the future.
For now, it detects issues such as:
https://www.hashicorp.com/blog/protecting-consul-from-rce-risk-in-specific-configurations/
This would display this kind of messages: