-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new golang version 1.12.16 #7153
Conversation
Not sure we can merge this just yet -- CI is showing that the new version of Go isn't vendored on CircleCI's side. Are there specific features we want out of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd need either a workaround (source go from not the circleCI image, or wait until a new image is available. (Is there an update stream from circle that we can watch to see when 1.12.16 would be built?)
You'll also need to update scripts in build-support, as well as i think the consul-releases project FYI:
|
consul-releases PR: https://github.com/hashicorp/consul-releases/pull/26 |
@mkcp mostly because it has security fixes for windows: https://groups.google.com/forum/m/#!topic/golang-announce/Hsw4mHYc470. |
CircleCI image has arrived! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.