Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: [BUGFIX] Replaces destroyRecord with unloadRecord for KV 404's #5837

Merged
merged 1 commit into from
Jun 4, 2019
Merged

ui: [BUGFIX] Replaces destroyRecord with unloadRecord for KV 404's #5837

merged 1 commit into from
Jun 4, 2019

Commits on Jun 4, 2019

  1. ui: Replaces destroyRecord with unloadRecord for KV 404's 

    Just because Consul gives us a 404 this doesn't guarantee the KV doesn't
exist, it doesn't even mean we don't have access to it. Furthermore we
should never destroyRecord's without user interaction (therefore only via the
repo.delete method).

This switches destroyRecord to unloadRecord which performs the
additional legwork to keep ember-data in sync with the actual truth.

unloadRecord unloads the record from ember-data rather than sending an API
delete request, which would have been the intent here.
    John Cowen committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    16631eb View commit details
    Browse the repository at this point in the history