Healthcheck duration fix #5276
Merged
Healthcheck duration fix #5276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyhavlov
force-pushed
the
healthcheck-duration-fix
branch
from
231804a to
a9e73ec
Compare
This is to fix the backwards-incompatible change made in 1.4.1 by changing these fields to time.Duration.
kyhavlov
force-pushed
the
healthcheck-duration-fix
branch
from
a9e73ec to
1a4978f
Compare
mkeeler
requested changes
Jan 28, 2019
mkeeler
requested changes
Jan 28, 2019
Co-Authored-By: kyhavlov <[email protected]>
mkeeler
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I re-added the ReadableDuration fields to the health check definition struct on top of @i0rek's changes to maintain backwards compatibility with the older client api code.