Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable tests #4645

Merged
merged 10 commits into from
Sep 10, 2018
Merged

Fix unstable tests #4645

merged 10 commits into from
Sep 10, 2018

Conversation

pierresouchay
Copy link
Contributor

@freddygv This fixes unstable tests found while working on #4605

freddygv
freddygv approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks Pierre!

I like what you did for the API package. Those lock tests are far more stable now.

@freddygv freddygv merged commit 22500f2 into hashicorp:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierresouchay @freddygv