Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raft Protocol vs Consul Protocol Doc Clarification #2865

Merged
merged 3 commits into from
Apr 4, 2017

Conversation

moofish32
Copy link
Contributor

I do not know if I have this correct. I am unclear if protocol version and raft version are the same. Based on the info in Specific Version Details and Compatibility Section it's a little confusing. I'll do the editing if somebody can give a little clarification.

@slackpad
Copy link
Contributor

slackpad commented Apr 3, 2017

Hey @moofish32 thanks for taking this up! The Raft protocol version is a totally separate and new thing for 0.8, so that would be worth making clear here. The Raft protocol version only affects servers and enables certain new autopilot features, so we could probably link to https://www.consul.io/docs/upgrade-specific.html#raft-protocol-version-compatibility for more details. Thinking about your confusion we could have maybe rolled it into the protocol version, but it's so specific and only affects servers, so we made it its own thing. After 0.9 it'll default to the latest and shouldn't need to be updated again (hopefully).

Also in the diff here, 0.8 doesn't support back to protocol version 1, we shed that in version 0.7.

@moofish32 moofish32 changed the title Doc Update for Compatibility Section Raft Protocol vs Consul Protocol Doc Clarification Apr 4, 2017
@moofish32 moofish32 force-pushed the doc/v8-compatibility branch from f1cd589 to b7851b2 Compare April 4, 2017 07:18
@@ -49,7 +49,7 @@ When upgrading to Consul 0.8.0 from a version lower than 0.7.0, users will need
set the [`-raft-protocol`](/docs/agent/options.html#_raft_protocol) option to 1 in
order to maintain backwards compatibility with the old servers during the upgrade.
After the servers have been migrated to version 0.8.0, `-raft-protocol` can be moved
up to 2 and the servers restarted to match the default.
up to 3 and the servers restarted to match the default.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slackpad - Once all servers are migrated to 0.8 should the servers be restarted with 3 or 2? Is there something special in Raft v2? I separated this commit, so it's easily dropped.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a special case for people running pre-0.7 Consul versions, so 2 was right here.

@moofish32
Copy link
Contributor Author

moofish32 commented Apr 4, 2017

@slackpad - I'm not a frontend guru, but I made a change to condense the table a bit. Happy to go back and add in one line per version. I had one more question on the Raft version migration section.

@slackpad slackpad merged commit 8471360 into hashicorp:master Apr 4, 2017
@slackpad
Copy link
Contributor

slackpad commented Apr 4, 2017

@moofish32 thanks for cleaning this up!

@moofish32 moofish32 deleted the doc/v8-compatibility branch April 5, 2017 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants