Prepare for release of 1.20.0 #21827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
pr/no-changelog
github-actions
bot
added
theme/api
nathancoleman
commented
Oct 14, 2024
| github.com/hashicorp/consul/proto-public v0.5.4-rc1 | ||
| github.com/hashicorp/consul/proto-public v0.6.3 |
There was a problem hiding this comment.
The RC should have been v0.6.3-rc1 but was off due to incorrect instructions that have now been corrected.
The correct version, v0.6.3, has now been released. There will not be a v0.5.4 as a result.
| @@ -44,8 +44,6 @@ github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/ | |||
| github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38= | |||
| github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY= | |||
| github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg= | |||
| github.com/hashicorp/consul/proto-public v0.5.4-rc1 h1:psIJ9DgJw5QbRsh6RGYYr3Viw+r+up9PE7Z6mAZsAEQ= | |||
| github.com/hashicorp/consul/proto-public v0.5.4-rc1/go.mod h1:a1pOtKbQ2+iRnMlEA2bywlEZ0nbCQ2pS7GDQN6pqLwU= | |||
There was a problem hiding this comment.
I believe these were incorrectly included in the RC branch, which release/1.20.0 originated from. Checking other releases (1.19.0 for example), these go.sum entries shouldn't be present and the go.mod replacements should be present.
You'll see similar cases in the go.sum files below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update submodule dependencies + changelog
Testing & Reproduction steps
Links
PR Checklist