Upgrade test improvements for 1.20.x #21813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
pr/no-changelog
NiniOak
approved these changes
Oct 11, 2024
github-actions
bot
added
type/ci
4 tasks
missylbytes
pushed a commit
that referenced
this pull request
Oct 29, 2024
* Bump Envoy version used for 1.20.x upgrade tests * Improve README + docstrings
missylbytes
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Bump Envoy version used for 1.20.x upgrade tests * Improve README + docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade tests targeting Consul
1.20.0-rc1are currently failing. This is due to the Envoy version not being pinned properly for this particular set of tests.In addition, I updated the docs where I caught some typos and missing line breaks.
Testing & Reproduction steps
Run the nightly integration tests using this branch (example)
Links
See above for a run of the failing upgrade tests that pass when using this branch.
PR Checklist