Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: document behaviour of tls.https.verify_outgoing into release/1.12.x #20609

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #20555 to be assessed for backporting due to the inclusion of the label backport/1.12.

The below text is copied from the body of the original PR.


At first it's not clear what verify_outgoing would do for the https listener as it seems like Consul agent's don't make https requests. Upon further investigation, it's clear that Consul agents do make https requests in the following scenarios:

  • to implement watches
  • to perform checks

In the first scenario, this setting is used here:

func (c *RuntimeConfig) APIConfig(includeClientCerts bool) (*api.Config, error) {

In the second scenario, it's actually the internal_rpc setting that is used:

config := c.internalRPCTLSConfig(false)


Overview of commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core
Copy link
Collaborator Author

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul February 13, 2024 17:02 Inactive
@lkysow lkysow enabled auto-merge (squash) February 13, 2024 17:18
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Apr 14, 2024
@lkysow
Copy link
Member

lkysow commented Apr 15, 2024

Closing because not critical this makes it into 1.12.x docs.

@lkysow lkysow closed this Apr 15, 2024
auto-merge was automatically disabled April 15, 2024 16:46

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta/stale Automatically flagged for inactivity by stalebot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants