Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of ci: Single source of truth for Go version in CI and Dockerfile into release/1.17.x #20160

Merged

Conversation

zalimeni
Copy link
Member

@zalimeni zalimeni commented Jan 11, 2024

Manual backport of #20058 to release/1.17.x.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern
Overview of commits
  • 521493732f3f36908845751a978b4a88e1690301

@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Jan 11, 2024
@zalimeni zalimeni force-pushed the backport/zalimeni/use-go-version-file/manual-1.17.x branch from 0bb79ff to 584f1ac Compare January 11, 2024 01:18
@zalimeni zalimeni marked this pull request as ready for review January 11, 2024 14:23
@zalimeni zalimeni requested a review from a team January 11, 2024 14:23
@zalimeni zalimeni requested a review from a team as a code owner January 11, 2024 14:23
@zalimeni zalimeni requested review from modrake, claire-labry, curtbushko and wilkermichael and removed request for a team January 11, 2024 14:23
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think just to make backports easier on these files it is ok to include the other 2 files:

nightly-test-integ-peering_commontopo.yml
nightly-test-integrations-1.17.x.yml

At least for these files they won't be triggered because cron jobs only start off of main.

@zalimeni
Copy link
Member Author

zalimeni commented Jan 11, 2024

I think just to make backports easier on these files it is ok to include the other 2 files:

nightly-test-integ-peering_commontopo.yml
nightly-test-integrations-1.17.x.yml

At least for these files they won't be triggered because cron jobs only start off of main.

@curtbushko hmm, that's a fair point. I kept it status-quo in this change, but it might be worthwhile to add them down the chain. I might do that as a follow-up since these PRs are already green, if that works for you.

Thanks for the review!

@zalimeni zalimeni merged commit a0c9b5e into release/1.17.x Jan 11, 2024
98 checks passed
@zalimeni zalimeni deleted the backport/zalimeni/use-go-version-file/manual-1.17.x branch January 11, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport theme/contributing Additions and enhancements to community contributing materials type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants