Add min/max kubetags to meshgatewaylistener #20149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sarahalsmiller
added
pr/no-changelog
sarahalsmiller
requested review from
a team,
andrewstucki and
NiniOak
and removed request for
a team
NiniOak
reviewed
Jan 10, 2024
| @@ -19,5 +19,7 @@ message MeshGateway { | |||
|
|
|||
| message MeshGatewayListener { | |||
| string name = 1; | |||
| // +kubebuilder:validation:Maximum=65535 | |||
| // +kubebuilder:validation:Minimum=0 | |||
NiniOak
approved these changes
Jan 10, 2024
sarahalsmiller
force-pushed
the
NET-6822-consul-consul-k8s-Add-listeners-to-MeshGateway-consume-for-Service
branch
from
fba4008
to
c4b538e
Compare
sarahalsmiller
deleted the
NET-6822-consul-consul-k8s-Add-listeners-to-MeshGateway-consume-for-Service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing & Reproduction steps
Links
PR Checklist