-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of docs/consul: rename the Vault secret engine for Consul integration into release/1.14.x #20088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approved Consul Bot automated PR
🤔 This PR has changes in the |
Manual backport PR |
…factually-enough-buck
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review. |
Pull request was closed
Backport
This PR is auto-generated from #20049 to be assessed for backporting due to the inclusion of the label backport/1.14.
🚨
The person who merged in the original PR is:
@krastin
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Description
There was feedback from our Support team about customers facing an issue following the documentation from the Vault for Consul: System integration into the Vault for Consul: Data integration. The former defines a
consul
-named Vault secret engine, but the latter runs commands and config against asecrets
-named Vault secret engine - no doubt a leftover from times where the default secret engine from running Vault in-dev
mode was used to showcase functionality in the docs.Furthermore, because of the secret engine name
consul
, the customers were confused and expected the secret engine to be of the Consul type and not the KV type.With that in mind, this PR changes the docs in the following way:
consul-kv
secrets
is being used for all token-related configuration so that in Production environments, that specific path can be allowed/disallowed read/write access easier for separate admin and non-admin user roles.Testing & Reproduction steps
N/A
Links
Related Docs: Vault as the Secrets Backend (K8s)
PR Checklist
Overview of commits