Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add acl token #20086

Merged
merged 1 commit into from
Jan 16, 2024
Merged

add acl token #20086

merged 1 commit into from
Jan 16, 2024

Conversation

wangxinyi7
Copy link
Member

@wangxinyi7 wangxinyi7 commented Jan 5, 2024 •
edited
Loading

Description

In this PR, we add the ACL token and tokenFile fields into GRPC config.

Notice the field of tokenFile takes precedence over the token field.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-actions github-actions bot added theme/cli Flags and documentation for the CLI interface and removed pr/no-backport labels Jan 5, 2024
@wangxinyi7 wangxinyi7 added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport and removed theme/cli Flags and documentation for the CLI interface labels Jan 5, 2024
@wangxinyi7 wangxinyi7 mentioned this pull request Jan 8, 2024
Merged
4 tasks
@wangxinyi7 wangxinyi7 merged commit a879dea into main Jan 16, 2024
106 of 109 checks passed
@wangxinyi7 wangxinyi7 deleted the xw/NET-7077-ACL-token branch January 16, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

@dhiaayachi dhiaayachi Awaiting requested review from dhiaayachi

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangxinyi7 @mkeeler